-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP keep PyYAML build working on Cython3.0.0a10+ #602
Draft
nitzmahone
wants to merge
1
commit into
yaml:main
Choose a base branch
from
nitzmahone:cython3test
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cython 3.0 changes its build_ext command base class to one that's incompatible with pyyaml's subclass * temporarily force use of Cython3's `old_build_ext` compatibility class if present
hswong3i
added a commit
to alvistack/yaml-pyyaml
that referenced
this pull request
Jul 19, 2023
git clean -xdf tar zcvf ../python-yaml_6.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-yaml.spec ../python-yaml_6.0.1-1.spec mv ../python*-yaml*6.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0.1/ rm -rf ../python*-yaml*6.0.1*.* See yaml#602 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/yaml-pyyaml
that referenced
this pull request
Jul 19, 2023
git clean -xdf tar zcvf ../python-yaml_6.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-yaml.spec ../python-yaml_6.0.1-1.spec mv ../python*-yaml*6.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0.1/ rm -rf ../python*-yaml*6.0.1*.* See yaml#602 See https://build.opensuse.org/package/view_file/devel:languages:python/python-PyYAML/setuptools.patch Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/yaml-pyyaml
that referenced
this pull request
Jul 19, 2023
git clean -xdf tar zcvf ../python-yaml_6.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-yaml.spec ../python-yaml_6.0-1.spec mv ../python*-yaml*6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0/ rm -rf ../python*-yaml*6.0*.* See yaml#602 See https://build.opensuse.org/package/view_file/devel:languages:python/python-PyYAML/setuptools.patch Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/yaml-pyyaml
that referenced
this pull request
Jul 19, 2023
git clean -xdf tar zcvf ../python-yaml_6.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-yaml.spec ../python-yaml_6.0.1-1.spec mv ../python*-yaml*6.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0.1/ rm -rf ../python*-yaml*6.0.1*.* See yaml#602 See https://build.opensuse.org/package/view_file/devel:languages:python/python-PyYAML/setuptools.patch Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
This was referenced Jul 26, 2023
@nitzmahone: can you close this? #731 seems to implement basically the same thing without the explicit Cython version dependency. According to reports it works on pyyaml 5.4 and 6.0 branches. Thanks. |
This was referenced Jul 26, 2023
Hi @nitzmahone any update on this support, have we added this or is it still WIP. |
m-kuhn
added a commit
to open-vcpkg/python-registry
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #601
old_build_ext
compatibility class if present