Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP keep PyYAML build working on Cython3.0.0a10+ #602

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nitzmahone
Copy link
Member

@nitzmahone nitzmahone commented Jan 12, 2022

fixes #601

  • Cython 3.0 changes its build_ext command base class to one that's incompatible with pyyaml's subclass
  • temporarily force use of Cython3's old_build_ext compatibility class if present

* Cython 3.0 changes its build_ext command base class to one that's incompatible with pyyaml's subclass
* temporarily force use of Cython3's `old_build_ext` compatibility class if present
hswong3i added a commit to alvistack/yaml-pyyaml that referenced this pull request Jul 19, 2023
    git clean -xdf
    tar zcvf ../python-yaml_6.0.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-yaml.spec ../python-yaml_6.0.1-1.spec
    mv ../python*-yaml*6.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0.1/
    rm -rf ../python*-yaml*6.0.1*.*

See yaml#602

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/yaml-pyyaml that referenced this pull request Jul 19, 2023
    git clean -xdf
    tar zcvf ../python-yaml_6.0.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-yaml.spec ../python-yaml_6.0.1-1.spec
    mv ../python*-yaml*6.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0.1/
    rm -rf ../python*-yaml*6.0.1*.*

See yaml#602
See https://build.opensuse.org/package/view_file/devel:languages:python/python-PyYAML/setuptools.patch

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/yaml-pyyaml that referenced this pull request Jul 19, 2023
    git clean -xdf
    tar zcvf ../python-yaml_6.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-yaml.spec ../python-yaml_6.0-1.spec
    mv ../python*-yaml*6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0/
    rm -rf ../python*-yaml*6.0*.*

See yaml#602
See https://build.opensuse.org/package/view_file/devel:languages:python/python-PyYAML/setuptools.patch

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/yaml-pyyaml that referenced this pull request Jul 19, 2023
    git clean -xdf
    tar zcvf ../python-yaml_6.0.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-yaml.spec ../python-yaml_6.0.1-1.spec
    mv ../python*-yaml*6.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/yaml-pyyaml-6.0.1/
    rm -rf ../python*-yaml*6.0.1*.*

See yaml#602
See https://build.opensuse.org/package/view_file/devel:languages:python/python-PyYAML/setuptools.patch

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@SoftwareApe
Copy link

SoftwareApe commented Jul 21, 2023

Alternative fix that works for both Cython versions: #729.

EDIT: Closed #729 in favor of #731. Please apply it to 5.4.1 release branch as well, since we need a fix there.

@Uzume
Copy link

Uzume commented Jul 26, 2023

@nitzmahone: can you close this? #731 seems to implement basically the same thing without the explicit Cython version dependency. According to reports it works on pyyaml 5.4 and 6.0 branches. Thanks.

@kartikkhunda
Copy link

Hi @nitzmahone any update on this support, have we added this or is it still WIP.

m-kuhn added a commit to open-vcpkg/python-registry that referenced this pull request May 13, 2024
@Uzume Uzume mentioned this pull request May 18, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"AttributeError: cython_sources" with Cython 3.0.0a10
4 participants