Ignore python_requires when installing with distutils #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using python setup.py <command>, distutils.dist.Distribution does not recognize python_requires (unlike setuptools) and will issue an obnoxious warning that doesn't actually tell the user that their Python version is not supported. Note that this (might not be) the case with pip since it replaces distutils with setuptools, which does support it. The other possible solution would be to parse python_requires, but that requires a lot of work (see pip/_internals/utils/packaging.py) and is an example of the reason setuptools was made in the first place.
bsolomon1124
force-pushed
the
distutils-ignore-python-requires
branch
from
9a4000b
to
758a99f
Compare
|
This might be a non-issue (I think?), if we end up merging some form of #224 (which I'm leaning toward). I've added it to the 5.4 project, so hopefully we can figure out soon which way to go. |
|
handled in #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
python setup.py <command>, distutils.dist.Distributiondoes not recognize python_requires (unlike setuptools) and will
issue an obnoxious warning that doesn't actually tell the user
that their Python version is not supported.
Note that this (might not be) the case with pip since it replaces
distutils with setuptools, which does support it.
The other possible solution would be to parse python_requires,
but that requires a lot of work (see pip/_internals/utils/packaging.py)
and is an example of the reason setuptools was made in the first place.