Change default Loader for add_constructor to FullLoader #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueljsb
pushed a commit
to unipartdigital/odoo
that referenced
this pull request
Apr 4, 2019
pyYAML 5.1 is now the distro version. This introduces the requirement to specify a loader when loading yaml. There is a known issue ( yaml/pyyaml#274 ) with the add_constructor method not assignign the correct default loader. This commit assigns the default FullLoader, allowing the constructors to be used again. Task: 3761 Signed-off-by: Samuel Searles-Bryant <samuel.searles-bryant@unipart.io>
This was referenced Apr 4, 2019
Closed
samueljsb
pushed a commit
to unipartdigital/udes-tester
that referenced
this pull request
Apr 4, 2019
There is a known issue with pyYAML 5.1 (yaml/pyyaml#274) which does not assign a default loader to the add_constructor method. This ensures that a pre-5.1 version of pyYAML is being used. Task: 3716 Signed-off-by: Samuel Searles-Bryant <samuel.searles-bryant@unipart.io>
|
Is this going to be included in the next release? |
samueljsb
pushed a commit
to unipartdigital/odoo
that referenced
this pull request
Apr 26, 2019
pyYAML 5.1 is now the distro version. This introduces the FullLoader as the default loader used with yaml.load(…), however the default loader for yaml.add_constructor(…) has not been updated (This is a known issue: yaml/pyyaml#274). This commit specifies the loader to be used when adding constructors, using the FullLoader if it exists and the older Loader if not (i.e. depending on which version of pyYAML is installed). Task: 3958 Signed-off-by: Samuel Searles-Bryant <samuel.searles-bryant@unipart.io>
samueljsb
pushed a commit
to unipartdigital/odoo
that referenced
this pull request
Apr 26, 2019
pyYAML 5.1 is now the distro version. This introduces the FullLoader as the default loader used with yaml.load(…), however, the default loader for yaml.add_constructor(…) has not been updated (this is a known issue: yaml/pyyaml#274). This commit specifies the loader to be used when adding constructors, using the FullLoader if it exists and the older Loader if not (i.e. depending on which version of pyYAML is installed). Task: 3958 Signed-off-by: Samuel Searles-Bryant <samuel.searles-bryant@unipart.io>
|
I think @ingydotnet wants to release #287 instead |
|
Oh perfect, that also solves my problem! |
|
Closing, replaced by #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271