Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default loader for YAMLObject classes to FullLoader #273

Closed
wants to merge 1 commit into from

Conversation

perlpunk
Copy link
Member

Fixes #266

The default loader for yaml.load is yaml.FullLoader, so the default
for the YAMLObject class should also be changed.

@kgutwin
Copy link

kgutwin commented Mar 16, 2019

This is a good short-term fix, but you’ll still have some users confused as to why their use of YAMLObject as shown in the documentation doesn’t work with yaml.safe_load (for example). The documentation should also be updated to explain when it would make sense for users to set the yaml_loader and yaml_dumper variables.

@ingydotnet
Copy link
Member

@perlpunk @kgutwin Please take a look at #279.

@perlpunk perlpunk moved this from PRs and Notes to Consider to Other completed tasks in 5.2 Release Mar 31, 2019
@perlpunk perlpunk moved this from Other completed tasks to Won't fix in 5.2 Release Mar 31, 2019
@perlpunk
Copy link
Member Author

perlpunk commented Dec 2, 2019

Closing, replaced by #279

@perlpunk perlpunk closed this Dec 2, 2019
@perlpunk perlpunk deleted the perlpunk/yamlobject branch December 2, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.2 Release
Won't fix
Development

Successfully merging this pull request may close these issues.

ConstructorError - could not determine a constructor for custom tag (5.1)
3 participants