Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making python 3.7 + compatible #212

Closed
wants to merge 1 commit into from
Closed

Conversation

Keyrat06
Copy link

Python warning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

Python warning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works back to Python3.3, so LGTM

@webknjaz
Copy link

Should I absorb this commit into #172, which also enables testing against proper Python 3.7?

@Keyrat06
Copy link
Author

Sure, sounds good to me.

@webknjaz
Copy link

Done!

@The-Compiler
Copy link
Contributor

Duplicate of #181 FWIW.

@webknjaz
Copy link

@The-Compiler also absorbed into #172, which also enables testing. I hope it'll get reviewed and merged at some point

@naphthalene
Copy link

LGTM! Is there a release planned?

@kishanterry
Copy link

When is this PR expected to be merged and released?

@blazingkin
Copy link

I would also like to know when this PR will be released

@ingydotnet
Copy link
Member

@blazingkin In the next release. Hopefully in February.

@stratosgear
Copy link

Also looking forward for this.

The DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working warning, "pollutes" my tox outputs :)

@et304383
Copy link

Can we please get this merged in?

@perlpunk perlpunk added this to Backlog in 5.3 Release Dec 7, 2019
@perlpunk
Copy link
Member

perlpunk commented Dec 7, 2019

Is this still needed since #181 was merged already?

@webknjaz
Copy link

webknjaz commented Dec 8, 2019

You can close this one then

@perlpunk
Copy link
Member

perlpunk commented Dec 8, 2019

Thanks!

@perlpunk perlpunk closed this Dec 8, 2019
@perlpunk perlpunk removed this from Backlog in 5.3 Release Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet