Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing of py37 release #200

Closed
wants to merge 1 commit into from
Closed

Conversation

ssbarnea
Copy link

@ssbarnea ssbarnea commented Jul 3, 2018

Activates py37 target in travis instead of the outdated 3.7-dev version.

Signed-off-by: Sorin Sbarnea ssbarnea@redhat.com

Activates py37 target in travis instead of the outdated 3.7-dev version.

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
@ingydotnet
Copy link
Member

@ssbarnea thanks.

We'll apply this after we release PyYAML 3.13 (planned for this week). See #193

@webknjaz
Copy link

webknjaz commented Jul 6, 2018

Hey @ssbarnea it's already included in my PR #172

@webknjaz
Copy link

Duplicates #172

env: TOXENV=py37
# begin: workaround to enable support for py37:
sudo: required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis are now recommending removing the sudo tag.

"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I addressed that in my PR which is hopefully going to be merged soon

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, sudo was needed in order to install the newer py37. If that is not needed anymore we can drop it.

Travis recommented not using sudo from day one but reality is that quite often I faced myself in cases where sudo was mandatory for testing some stuff.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI sunsetted their container-based infra. Everyone gets VMs now. So this option is basically garbage, therefore.

Copy link
Author

@ssbarnea ssbarnea Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch.... not sure what to say about that. While I am fully aware that there are jobs that may not work as docker containers, they count probably for les that 0.1%. I guess it translates to "we failed to manage a production cluster". I guess it goes along the line with https://www.reddit.com/r/programming/comments/8avdrl/travis_ci_dropped_production_database_by/ :)

I guess i need to start using a rss client again as I missed it https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures

@perlpunk
Copy link
Member

perlpunk commented Dec 7, 2019

Thanks! This was fixed by #345 meanwhile

@perlpunk perlpunk closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants