Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Python 2.6 & 3.3 #105

Merged
merged 11 commits into from Feb 24, 2019
Merged

Removed Python 2.6 & 3.3 #105

merged 11 commits into from Feb 24, 2019

Conversation

engnadeau
Copy link

@engnadeau engnadeau commented Dec 3, 2017

DEPRECATION: Python 2.6 is no longer supported by the Python core team
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engnadeau
Copy link
Author

@hugovk thanks for the reminder! Travis passes now

@engnadeau
Copy link
Author

@alex @dstufft @hugovk is there anything else you'd like me to look into?

Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It would be good to add this to setup() in setup.py, so pip will install the correct distribution for the user's Python version:

python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',

@engnadeau engnadeau changed the title Removed Python 2.6 Removed Python 2.6 & 3.3 Dec 8, 2017
@alex
Copy link
Contributor

alex commented Dec 8, 2017

I'd encourage the PyYAML maintainers to land this in a separate release from the current master. That is because master includes making PyYAML safe by default, and I don't want that to be denied to people who are (depressingly) insistent on using 2.6.

@engnadeau
Copy link
Author

engnadeau commented Dec 8, 2017

@hugovk following your python_requires suggestion, I also noted that Py3.3 is EoL as well. The following commits also clean this up:

However, if you prefer, I can move this into its own PR

@alex, Python 2.6 builds are not passing on master...

@alex
Copy link
Contributor

alex commented Dec 9, 2017

They're failing because we install a version of wheel that's too new. I'm not saying this is good, I'd be very happy for Python 2.6 to die a firey death, but given the choice between YAML RCEs and Python2.6 fixes, I want everyone to get the RCE fixes.

@hugovk
Copy link
Contributor

hugovk commented Dec 9, 2017

As a compromise, how about making a release quite soon with the RCE fixes, then merging this right after release?

@alex
Copy link
Contributor

alex commented Dec 9, 2017

That sounds great to me. To the PyYAML maintainers: if there's anything I can do to help get a release out, please let me know!

@engnadeau
Copy link
Author

@hugovk is there an open issue for YAML RCEs that we can link this PR to?

@hugovk
Copy link
Contributor

hugovk commented Dec 10, 2017

Let's ask @alex.

@alex
Copy link
Contributor

alex commented Dec 10, 2017

#74

@engnadeau
Copy link
Author

Happy New Year @alex @hugovk @jdufresne !

What's the status of this PR?

@hugovk
Copy link
Contributor

hugovk commented Jan 5, 2018

Looks good to me, but I don't think any of us three can merge.

@engnadeau
Copy link
Author

Ahh! @sigmavirus24 is the merger :)

@gdubicki
Copy link

Python 2.6 tests are blocking #143 , which I care about. Can you please take a look at this MR, @sigmavirus24 ? Or otherwise perhaps share your permission with people who have more time for this project? Thanks in advance! :)

@perlpunk
Copy link
Member

@gdubicki I believe tests for #143 were failing because of some travis + 2.6 issue. I just rebased my PR to master and force-pushed. 2.6 is passing now, waiting for 3.7-dev

@cclauss
Copy link
Contributor

cclauss commented Feb 24, 2019

Perfect timing... 20 days until Python 3.4 end of life.

print((date(2019, 3, 16) - date.today()).days, 'days until Python 3.4 end of life.')

https://devguide.python.org/index?#status-of-python-branches

nitzmahone added a commit that referenced this pull request Feb 24, 2019
@ingydotnet ingydotnet moved this from Possible PRs and To Do items to Added to release/5/1 branch in 5.1 Release Feb 24, 2019
ingydotnet pushed a commit that referenced this pull request Feb 25, 2019
ingydotnet pushed a commit that referenced this pull request Feb 25, 2019
@engnadeau engnadeau deleted the patch-1 branch February 25, 2019 17:49
ingydotnet pushed a commit that referenced this pull request Feb 26, 2019
ingydotnet pushed a commit that referenced this pull request Feb 28, 2019
ingydotnet pushed a commit that referenced this pull request Mar 7, 2019
ingydotnet pushed a commit that referenced this pull request Mar 8, 2019
ingydotnet pushed a commit that referenced this pull request Mar 8, 2019
mtremer pushed a commit to ipfire/ipfire-2.x that referenced this pull request Feb 14, 2022
- Update from 3.13 to 6.0
- Update of rootfile
- Changelog
6.0 (2021-10-13)
* yaml/pyyaml#327 -- Change README format to Markdown
* yaml/pyyaml#483 -- Add a test for YAML 1.1 types
* yaml/pyyaml#497 -- fix float resolver to ignore `.` and `._`
* yaml/pyyaml#550 -- drop Python 2.7
* yaml/pyyaml#553 -- Fix spelling of “hexadecimal”
* yaml/pyyaml#556 -- fix representation of Enum subclasses
* yaml/pyyaml#557 -- fix libyaml extension compiler warnings
* yaml/pyyaml#560 -- fix ResourceWarning on leaked file descriptors
* yaml/pyyaml#561 -- always require `Loader` arg to `yaml.load()`
* yaml/pyyaml#564 -- remove remaining direct distutils usage
5.4.1 (2021-01-20)
* yaml/pyyaml#480 -- Fix stub compat with older pyyaml versions that may unwittingly load it
5.4 (2021-01-19)
* yaml/pyyaml#407 -- Build modernization, remove distutils, fix metadata, build wheels, CI to GHA
* yaml/pyyaml#472 -- Fix for CVE-2020-14343, moves arbitrary python tags to UnsafeLoader
* yaml/pyyaml#441 -- Fix memory leak in implicit resolver setup
* yaml/pyyaml#392 -- Fix py2 copy support for timezone objects
* yaml/pyyaml#378 -- Fix compatibility with Jython
5.3.1 (2020-03-18)
* yaml/pyyaml#386 -- Prevents arbitrary code execution during python/object/new constructor
5.3 (2020-01-06)
* yaml/pyyaml#290 -- Use `is` instead of equality for comparing with `None`
* yaml/pyyaml#270 -- Fix typos and stylistic nit
* yaml/pyyaml#309 -- Fix up small typo
* yaml/pyyaml#161 -- Fix handling of __slots__
* yaml/pyyaml#358 -- Allow calling add_multi_constructor with None
* yaml/pyyaml#285 -- Add use of safe_load() function in README
* yaml/pyyaml#351 -- Fix reader for Unicode code points over 0xFFFF
* yaml/pyyaml#360 -- Enable certain unicode tests when maxunicode not > 0xffff
* yaml/pyyaml#359 -- Use full_load in yaml-highlight example
* yaml/pyyaml#244 -- Document that PyYAML is implemented with Cython
* yaml/pyyaml#329 -- Fix for Python 3.10
* yaml/pyyaml#310 -- Increase size of index, line, and column fields
* yaml/pyyaml#260 -- Remove some unused imports
* yaml/pyyaml#163 -- Create timezone-aware datetimes when parsed as such
* yaml/pyyaml#363 -- Add tests for timezone
5.2 (2019-12-02)
* Repair incompatibilities introduced with 5.1. The default Loader was changed,
  but several methods like add_constructor still used the old default
  yaml/pyyaml#279 -- A more flexible fix for custom tag constructors
  yaml/pyyaml#287 -- Change default loader for yaml.add_constructor
  yaml/pyyaml#305 -- Change default loader for add_implicit_resolver, add_path_resolver
* Make FullLoader safer by removing python/object/apply from the default FullLoader
  yaml/pyyaml#347 -- Move constructor for object/apply to UnsafeConstructor
* Fix bug introduced in 5.1 where quoting went wrong on systems with sys.maxunicode <= 0xffff
  yaml/pyyaml#276 -- Fix logic for quoting special characters
* Other PRs:
  yaml/pyyaml#280 -- Update CHANGES for 5.1
5.1.2 (2019-07-30)
* Re-release of 5.1 with regenerated Cython sources to build properly for Python 3.8b2+
5.1.1 (2019-06-05)
* Re-release of 5.1 with regenerated Cython sources to build properly for Python 3.8b1
5.1 (2019-03-13)
* yaml/pyyaml#35 -- Some modernization of the test running
* yaml/pyyaml#42 -- Install tox in a virtualenv
* yaml/pyyaml#45 -- Allow colon in a plain scalar in a flow context
* yaml/pyyaml#48 -- Fix typos
* yaml/pyyaml#55 -- Improve RepresenterError creation
* yaml/pyyaml#59 -- Resolves #57, update readme issues link
* yaml/pyyaml#60 -- Document and test Python 3.6 support
* yaml/pyyaml#61 -- Use Travis CI built in pip cache support
* yaml/pyyaml#62 -- Remove tox workaround for Travis CI
* yaml/pyyaml#63 -- Adding support to Unicode characters over codepoint 0xffff
* yaml/pyyaml#75 -- add 3.12 changelog
* yaml/pyyaml#76 -- Fallback to Pure Python if Compilation fails
* yaml/pyyaml#84 -- Drop unsupported Python 3.3
* yaml/pyyaml#102 -- Include license file in the generated wheel package
* yaml/pyyaml#105 -- Removed Python 2.6 & 3.3 support
* yaml/pyyaml#111 -- Remove commented out Psyco code
* yaml/pyyaml#129 -- Remove call to `ord` in lib3 emitter code
* yaml/pyyaml#149 -- Test on Python 3.7-dev
* yaml/pyyaml#158 -- Support escaped slash in double quotes "\/"
* yaml/pyyaml#175 -- Updated link to pypi in release announcement
* yaml/pyyaml#181 -- Import Hashable from collections.abc
* yaml/pyyaml#194 -- Reverting yaml/pyyaml#74
* yaml/pyyaml#195 -- Build libyaml on travis
* yaml/pyyaml#196 -- Force cython when building sdist
* yaml/pyyaml#254 -- Allow to turn off sorting keys in Dumper (2)
* yaml/pyyaml#256 -- Make default_flow_style=False
* yaml/pyyaml#257 -- Deprecate yaml.load and add FullLoader and UnsafeLoader classes
* yaml/pyyaml#261 -- Skip certain unicode tests when maxunicode not > 0xffff
* yaml/pyyaml#263 -- Windows Appveyor build

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>

 --git a/config/rootfiles/packages/python3-yaml b/config/rootfiles/packages/python3-yaml
x 0870a2346..bd4009a08 100644
* yaml/pyyaml#195 -- Build libyaml on travis
* yaml/pyyaml#196 -- Force cython when building sdist
* yaml/pyyaml#254 -- Allow to turn off sorting keys in Dumper (2)
* yaml/pyyaml#256 -- Make default_flow_style=False
* yaml/pyyaml#257 -- Deprecate yaml.load and add FullLoader and Uns
oader classes
* yaml/pyyaml#261 -- Skip certain unicode tests when maxunicode not
xffff
* yaml/pyyaml#263 -- Windows Appveyor build

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.1 Release
Added to release/5/1 branch
Development

Successfully merging this pull request may close these issues.

None yet