Merge pull request rails#35607 from y-yagi/ensure_application_work_wi…

…thout_tmp_directory Make application work without tmp directory
y-yagi · Mar 14, 2019 · b4079b1 · b4079b1
1 parent 4e649d1
commit b4079b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/railties/lib/rails/application.rb b/railties/lib/rails/application.rb
@@ -594,6 +594,7 @@ def generate_development_secret
 
           if !File.exist?(key_file)
             random_key = SecureRandom.hex(64)
+            FileUtils.mkdir_p(key_file.dirname)
             File.binwrite(key_file, random_key)
           end
 

diff --git a/railties/test/application/configuration_test.rb b/railties/test/application/configuration_test.rb
@@ -518,6 +518,9 @@ def index
         Rails.application.credentials.secret_key_base = nil
       RUBY
 
+      # For test that works even if tmp dir does not exist.
+      Dir.chdir(app_path) { FileUtils.remove_dir("tmp") }
+
       app "development"
 
       assert_not_nil app.secrets.secret_key_base