Downgrade xunit.runner.vs to net462 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clairernovotny here's the PR for the downgrade from net472 to net462. I also updated to the latest xunit preview package. |
|
Has this been tested--do you need to test the built version from the CI feed or should I go publish a new stable? |
|
Please publish the new version. I already verified offline that the produced package contains the expected assets. |
kevinoid
added a commit
to kevinoid/NetCoreProject
that referenced
this pull request
Nov 14, 2022
Since xunit.runner.visualstudio 2.4.5 only supports .NET 4.6.2 and later: xunit/visualstudio.xunit#308 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/NetCoreProject
that referenced
this pull request
Nov 14, 2022
Since xunit.runner.visualstudio 2.4.5 only supports .NET 4.6.2 and later: xunit/visualstudio.xunit#308 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/NLCaseConvert
that referenced
this pull request
Nov 15, 2022
Since xunit.runner.visualstudio 2.4.5 only supports .NET 4.6.2 and later: xunit/visualstudio.xunit#308 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #304 (comment) for context. .NETFramework 4.6.2 and above is still in support and support shouldn't be dropped for it from the package.