Ensure both failed tests and errors cancel for stopOnFail

xunit · Jul 5, 2023 · fd327b6 · fd327b6
1 parent 4e86b43
commit fd327b6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Versions.props b/Versions.props
@@ -9,7 +9,7 @@
     <NSubstituteVersion>5.0.0</NSubstituteVersion>
     <TunnelVisionLabsReferenceAssemblyAnnotatorVersion>1.0.0-alpha.160</TunnelVisionLabsReferenceAssemblyAnnotatorVersion>
     <XunitAnalyzersVersion>1.2.0-pre.48</XunitAnalyzersVersion>
-    <XunitVersion>2.5.0-pre.44</XunitVersion>
+    <XunitVersion>2.5.0-pre.45</XunitVersion>
   </PropertyGroup>
 
 </Project>
diff --git a/src/xunit.runner.visualstudio/VsTestRunner.cs b/src/xunit.runner.visualstudio/VsTestRunner.cs
@@ -578,7 +578,7 @@ static bool IsXunitPackageReferenced(string assemblyFileName)
 				resultsSink.Finished.WaitOne();
 
 				reporterMessageHandler.OnMessage(new TestAssemblyExecutionFinished(assembly, executionOptions, resultsSink.ExecutionSummary));
-				if (resultsSink.ExecutionSummary.Failed != 0 && executionOptions.GetStopOnTestFailOrDefault())
+				if ((resultsSink.ExecutionSummary.Failed != 0 || resultsSink.ExecutionSummary.Errors != 0) && executionOptions.GetStopOnTestFailOrDefault())
 				{
 					logger.Log("Canceling due to test failure...");
 					cancelled = true;