Add support for failSkips in configuration file

xunit · Jun 8, 2023 · 51bb552 · 51bb552
1 parent 8b9c453
commit 51bb552
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Versions.props b/Versions.props
@@ -2,13 +2,13 @@
 
   <PropertyGroup>
     <MicrosoftNetCoreAppRefVersion>6.0.11</MicrosoftNetCoreAppRefVersion>
-    <MicrosoftNetTestSdkVersion>17.6.0</MicrosoftNetTestSdkVersion>
+    <MicrosoftNetTestSdkVersion>17.6.2</MicrosoftNetTestSdkVersion>
     <MicrosoftSourceLinkGitHubVersion>1.1.1</MicrosoftSourceLinkGitHubVersion>
-    <MicrosoftTestPlatformObjectModelVersion>17.6.0</MicrosoftTestPlatformObjectModelVersion>
+    <MicrosoftTestPlatformObjectModelVersion>17.6.2</MicrosoftTestPlatformObjectModelVersion>
     <NerdbankGitVersioningVersion>3.6.133</NerdbankGitVersioningVersion>
     <NSubstituteVersion>5.0.0</NSubstituteVersion>
     <TunnelVisionLabsReferenceAssemblyAnnotatorVersion>1.0.0-alpha.160</TunnelVisionLabsReferenceAssemblyAnnotatorVersion>
-    <XunitVersion>2.5.0-pre.22</XunitVersion>
+    <XunitVersion>2.5.0-pre.24</XunitVersion>
   </PropertyGroup>
 
 </Project>
diff --git a/src/xunit.runner.visualstudio/VsTestRunner.cs b/src/xunit.runner.visualstudio/VsTestRunner.cs
@@ -567,6 +567,8 @@ static bool IsXunitPackageReferenced(string assemblyFileName)
 				IExecutionSink resultsSink = vsExecutionSink;
 				if (longRunningSeconds > 0)
 					resultsSink = new DelegatingLongRunningTestDetectionSink(resultsSink, TimeSpan.FromSeconds(longRunningSeconds), diagnosticSink);
+				if (configuration.FailSkipsOrDefault)
+					resultsSink = new DelegatingFailSkipSink(resultsSink);
 
 				controller.RunTests(testCases, resultsSink, executionOptions);
 				resultsSink.Finished.WaitOne();

diff --git a/test/xunit.runner.json b/test/xunit.runner.json
@@ -1,4 +1,5 @@
 {
+  "$schema": "https://xunit.net/schema/v2.5/xunit.runner.schema.json",
   "diagnosticMessages": true,
   "methodDisplay": "classAndMethod",
   "parallelizeAssembly": true