New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global object fix #4940
Update global object fix #4940
Conversation
`this` might be okay, I'm not actually sure, but xterm.js uses `globalThis` and so I think consistency is better maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any progress on this PR? I am also troubled by this problem, recompiling addon after using this patch works fine for me. |
@Tyriar Do you think this PR is something that could be merged in nearest future? Is anything needed here to unblock it? It's blocking usage of the library with nuxt (in SSR context it tends to fail). |
The changes are to the
webpack.config.js
files in each of the addon's folders. I set the global object toglobalThis
. I think this should fix the addons because when I import them, I get an error sayingself
is not defined.