Continuous underline dotted #4684
Conversation
|
emmm, file format ...... 😭 |
|
|
| ) { | ||
| if (cell.extended.underlineStyle === UnderlineStyle.DOTTED) { | ||
| const s = this._charSizeService.width; | ||
| variantOffset = ((deviceCellWidth! * chWidth) - variantOffset) % (lineWidth * 2); |
There was a problem hiding this comment.
For dotted, I would expect there only to be up to 2 * dot_size variants. So when the dot size is 1px, these would be the 2 variants for s:
There was a problem hiding this comment.
Yes, I also think so. The formula for calculating offset has not been written yet.
| this._model.cells[i + RENDER_MODEL_BG_OFFSET] === this._cellColorResolver.result.bg && | ||
| this._model.cells[i + RENDER_MODEL_FG_OFFSET] === this._cellColorResolver.result.fg && | ||
| this._model.cells[i + RENDER_MODEL_EXT_OFFSET] === this._cellColorResolver.result.ext && | ||
| this._model.cells[i + RENDER_MODEL_VARIANT_OFFSET] === variantOffset |
There was a problem hiding this comment.
GH somehow lost my lengthy comment on this line 🙁
I think we can avoid the extra 32 bytes here by packing the variant type into the remaining 3 unused bytes (up to 8 variants) in the ext value. Moving it into CellColorResolver.resolve would also make sense as that already takes the cell and column and augments the fg and bg.
There was a problem hiding this comment.
😨 I've sorted out the code and it's a bit messy. I've already figured out how to solve 2px+.
|
File formatting. I will restore it later. .... |
tisilent
force-pushed
the
underline-dotted-backup
branch
from
f051c6d
to
6f0a5c9
Compare
|
??...... why. |
https://github.com/tisilent/xterm.js into underline-dotted-backup
|
close,Resubmit. 😭. |
fix #4349
trial version
Font size above 26 is unstable.
Only processed webgl.
@Tyriar Is this idea feasible?