Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of memory retention problems #4185

Merged
merged 11 commits into from Oct 8, 2022
Merged

Fix a bunch of memory retention problems #4185

merged 11 commits into from Oct 8, 2022

Commits on Oct 8, 2022

  1. Polish emitter registering in canvas renderer 

    Part of xtermjs#4167
    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    f88c0e7 View commit details
    Browse the repository at this point in the history

  2. Ensure webgl texture atlas is released on dispose

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    fc8043a View commit details
    Browse the repository at this point in the history

  3. Free WebglAddon

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    56b37a7 View commit details
    Browse the repository at this point in the history

  4. Register webgl renderers

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    8116e03 View commit details
    Browse the repository at this point in the history

  5. Release canvas texture atlas

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    34475f2 View commit details
    Browse the repository at this point in the history

  6. Prevent overriding of Disposable.dispose 

    A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    ac659cb View commit details
    Browse the repository at this point in the history

  7. Properly register disposables in SearchAddon

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    f61d8c9 View commit details
    Browse the repository at this point in the history

  8. Register all event emitters, make some services disposable

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    00f6d3a View commit details
    Browse the repository at this point in the history

  9. Fix compile

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    94c3d11 View commit details
    Browse the repository at this point in the history

  10. Fix marker dispose unit tests

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    d3976c0 View commit details
    Browse the repository at this point in the history

  11. Fix Marker.dispose

    @Tyriar
    Tyriar committed Oct 8, 2022
    Copy the full SHA
    d8cf3af View commit details
    Browse the repository at this point in the history