Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unicode string handling in linkifier #1678

Merged
merged 29 commits into from Sep 14, 2018
Merged

Improve unicode string handling in linkifier #1678

merged 29 commits into from Sep 14, 2018

Commits on Sep 9, 2018

  1. Buffer.stringIndexToBufferIndex method

    @jerch
    jerch committed Sep 9, 2018
    Copy the full SHA
    a8fe410 View commit details
    Browse the repository at this point in the history

  2. BufferStringIterator

    @jerch
    jerch committed Sep 9, 2018
    Copy the full SHA
    a494e80 View commit details
    Browse the repository at this point in the history

  3. fix MockBuffer

    @jerch
    jerch committed Sep 9, 2018
    Copy the full SHA
    4aa8e40 View commit details
    Browse the repository at this point in the history

  4. change Linkifier._doLinkifyRow

    @jerch
    jerch committed Sep 9, 2018
    Copy the full SHA
    daa6fa0 View commit details
    Browse the repository at this point in the history

  5. linter errors

    @jerch
    jerch committed Sep 9, 2018
    Copy the full SHA
    08af72b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. fix multiple row linkifier attempts; tests for unicode before a match

    @jerch
    jerch committed Sep 10, 2018
    Copy the full SHA
    a76d4a6 View commit details
    Browse the repository at this point in the history

  2. merge master

    @jerch
    jerch committed Sep 10, 2018
    Copy the full SHA
    3289eed View commit details
    Browse the repository at this point in the history

  3. handle unicode within a match; test cases

    @jerch
    jerch committed Sep 10, 2018
    Copy the full SHA
    c35306a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_linkifier

    @jerch
    jerch committed Sep 10, 2018
    Copy the full SHA
    a2bfbea View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Merge branch 'master' into fix_linkifier

    @jerch
    jerch committed Sep 12, 2018
    Copy the full SHA
    0068c47 View commit details
    Browse the repository at this point in the history

  2. apply linkifier only to rows in viewport

    @jerch
    jerch committed Sep 12, 2018
    Copy the full SHA
    7e69c5d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. docs

    @jerch
    jerch committed Sep 13, 2018
    Copy the full SHA
    c8c22e3 View commit details
    Browse the repository at this point in the history

  2. fix next() invocation; handle wild matches

    @jerch
    jerch committed Sep 13, 2018
    Copy the full SHA
    2708a76 View commit details
    Browse the repository at this point in the history

  3. cover & comment right border trim behavior to be fixed

    @jerch
    jerch committed Sep 13, 2018
    Copy the full SHA
    30f74bf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_linkifier

    @jerch
    jerch committed Sep 13, 2018
    Copy the full SHA
    bd68853 View commit details
    Browse the repository at this point in the history

  5. make linter happy

    @jerch
    jerch committed Sep 13, 2018
    Copy the full SHA
    a8d9c92 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Remove unsafe cast in Buffer.test.ts

    @Tyriar
    Tyriar committed Sep 14, 2018
    Copy the full SHA
    7401567 View commit details
    Browse the repository at this point in the history

  2. 💄

    @Tyriar
    Tyriar committed Sep 14, 2018
    Copy the full SHA
    cd2ac92 View commit details
    Browse the repository at this point in the history

  3. Use common TestTerminal for writeSync across Buffer/Linkifier test

    @Tyriar
    Tyriar committed Sep 14, 2018
    Copy the full SHA
    50d6008 View commit details
    Browse the repository at this point in the history

  4. remove toArray; interface type for iterator result

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    9ce2894 View commit details
    Browse the repository at this point in the history

  5. cleanup BufferStringIterator

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    9514bfd View commit details
    Browse the repository at this point in the history

  6. rename contents to iterator

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    8664f54 View commit details
    Browse the repository at this point in the history

  7. rename stringWidth; add some comments

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    57bbbda View commit details
    Browse the repository at this point in the history

  8. simplify stringIndexToBufferIndex, fix docs

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    14c20c5 View commit details
    Browse the repository at this point in the history

  9. test cases for getStringCellWidth

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    70be55d View commit details
    Browse the repository at this point in the history

  10. fix test cases

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    631e331 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into fix_linkifier

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    3143ad7 View commit details
    Browse the repository at this point in the history

  12. hide regex error behind debug flag

    @jerch
    jerch committed Sep 14, 2018
    Copy the full SHA
    4b68976 View commit details
    Browse the repository at this point in the history

  13. 💄

    @Tyriar
    Tyriar committed Sep 14, 2018
    Copy the full SHA
    2f66ec4 View commit details
    Browse the repository at this point in the history