Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'isWrapped' of undefined at Buffer.getWrappedRangeForLine #1702

Closed
Tyriar opened this issue Sep 20, 2018 · 4 comments · Fixed by #1703
Closed
Assignees
Labels
area/links type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 20, 2018

image

@Tyriar Tyriar added the type/bug Something is misbehaving label Sep 20, 2018
@Tyriar Tyriar added this to the 3.8.0 milestone Sep 20, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Sep 20, 2018

image

image

@Tyriar
Copy link
Member Author

Tyriar commented Sep 20, 2018

It's happening because endIndex is being passed into iterator and it's invalid. In this example:

ydisp = 98
ybase = 98
absoluteRowIndexStart = 98
this._rowsToLinkify.start = 0
this._rowsToLinkify.end = 25
_endIndex = 124
_buffer.lines.length = 115
terminal.rows = 17

image

I think this is happening after a vertical resize down as I was tweaking font size/family before hitting this. Since the error was thrown once the this._rowsToLinkify.end value never gets set to null as it's at the end of that function, that's why I keep seeing the error despite the value of this._rowsToLinkify.end not making sense any more.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 20, 2018

FYI @jerch

@Tyriar Tyriar self-assigned this Sep 20, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 20, 2018
@jerch
Copy link
Member

jerch commented Sep 20, 2018

Hmm, was not able to repro it. The iterator does not do any sanity checks atm, gonna add them to #1693 (it alters the iterator logic anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/links type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants