isWrapped exception in terminal

[Tyriar]

xtermjs/xterm.js#1702

[IlyaBiryukov]

@Tyriar

I'm hitting an error about isWrapped property in 1.28.0, is this the same issue you just fixed?

In Chrome debug console:

TypeError: Cannot read property 'isWrapped' of undefined
    at Buffer.getWrappedRangeForLine (c:\Program Files\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Buffer.js:205)
    at BufferStringIterator.next (c:\Program Files\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Buffer.js:305)
    at Linkifier._linkifyRows (c:\Program Files\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Linkifier.js:63)
    at c:\Program Files\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Linkifier.js:53

[Tyriar]

@IlyaBiryukov yep, let me know if you see it again in Monday's build

[chrmarti]

Seeing this in todays build.

VS Code version: Code - Insiders 1.28.0-insider (5ba5f14, 2018-09-26T07:25:01.336Z)
OS version: Darwin x64 17.7.0

[Tyriar]

I guess my fix only covered one of the cases.

The latest xterm.js should fix this due to the additional bound checking in xtermjs/xterm.js#1693, but since this is an error I expect to have minimal impact on the actual experience, there were some issues when upgrading xterm.js last and because we're so late in the iteration, I'd say we hold off on this until 1.29.

[Tyriar]

Fixed in aaee349

[chrmarti]

@Tyriar This happens quite often (testing on Linux) and will make it difficult to spot other errors. I'd suggest to still fix this for the September milestone.

[StephenWeatherford]

This is annoying since it keeps bringing up the chrome debugging window. I'd said earlier it makes the terminal slow, I think that was not correct. But I do wonder if this is related to the fact that the terminal often isn't painting correctly.

[Tyriar]

This is not showing up in our error telemetry, I don't have a repro and pulling in the fix in isolation is non-trivial so I'm removing candidate.