Merge pull request #4290 from JasonXJ/alt-space

Send corresponding escape code for alt+space and ctrl+alt+space
xtermjs · Dec 7, 2022 · fe30cd6 · fe30cd6
2 parents 497df06 + 7f64fa9
commit fe30cd6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/common/input/Keyboard.test.ts b/src/common/input/Keyboard.test.ts
@@ -125,6 +125,12 @@ describe('Keyboard', () => {
       it('should return \\x1ba for alt+a', () => {
         assert.equal(testEvaluateKeyboardEvent({ altKey: true, keyCode: 65 }, { isMac: false }).key, '\x1ba');
       });
+      it('should return \\x1b\\x20 for alt+space', () => {
+        assert.equal(testEvaluateKeyboardEvent({ altKey: true, keyCode: 32 }, { isMac: false }).key, '\x1b\x20');
+      });
+      it('should return \\x1b\\x00 for ctrl+alt+space', () => {
+        assert.equal(testEvaluateKeyboardEvent({ altKey: true, ctrlKey: true, keyCode: 32 }, { isMac: false }).key, '\x1b\x00');
+      });
     });
 
     describe('On macOS platforms', () => {

diff --git a/src/common/input/Keyboard.ts b/src/common/input/Keyboard.ts
@@ -360,6 +360,8 @@ export function evaluateKeyboardEvent(
             keyString = keyString.toUpperCase();
           }
           result.key = C0.ESC + keyString;
+        } else if (ev.keyCode === 32) {
+          result.key = C0.ESC + (ev.ctrlKey ? C0.NUL : ' ');
         } else if (ev.key === 'Dead' && ev.code.startsWith('Key')) {
           // Reference: https://github.com/xtermjs/xterm.js/issues/3725
           // Alt will produce a "dead key" (initate composition) with some