Merge pull request #4204 from silamon/proposedApiCheck

Remove check proposed api checks
xtermjs · Oct 15, 2022 · aeba140 · aeba140
2 parents aea7680 + 073aa6d
commit aeba140
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/browser/public/Terminal.ts b/src/browser/public/Terminal.ts
@@ -78,7 +78,6 @@ export class Terminal implements ITerminalApi {
 
   public get element(): HTMLElement | undefined { return this._core.element; }
   public get parser(): IParser {
-    this._checkProposedApi();
     if (!this._parser) {
       this._parser = new ParserApi(this._core);
     }
@@ -92,7 +91,6 @@ export class Terminal implements ITerminalApi {
   public get rows(): number { return this._core.rows; }
   public get cols(): number { return this._core.cols; }
   public get buffer(): IBufferNamespaceApi {
-    this._checkProposedApi();
     if (!this._buffer) {
       this._buffer = new BufferNamespaceApi(this._core);
     }
@@ -148,7 +146,6 @@ export class Terminal implements ITerminalApi {
     this._core.attachCustomKeyEventHandler(customKeyEventHandler);
   }
   public registerLinkProvider(linkProvider: ILinkProvider): IDisposable {
-    this._checkProposedApi();
     return this._core.registerLinkProvider(linkProvider);
   }
   public registerCharacterJoiner(handler: (text: string) => [number, number][]): number {

diff --git a/src/headless/public/Terminal.test.ts b/src/headless/public/Terminal.test.ts
@@ -22,7 +22,7 @@ describe('Headless API Tests', function (): void {
 
   it('Proposed API check', async () => {
     term = new Terminal({ allowProposedApi: false });
-    throws(() => term.buffer, (error) => error.message === 'You must set the allowProposedApi option to true to use proposed API');
+    throws(() => term.markers, (error) => error.message === 'You must set the allowProposedApi option to true to use proposed API');
   });
 
   it('write', async () => {

diff --git a/test/api/Terminal.api.ts b/test/api/Terminal.api.ts
@@ -35,7 +35,7 @@ describe('API Integration Tests', function(): void {
     await openTerminal(page, { allowProposedApi: false });
     await page.evaluate(`
       try {
-        window.term.buffer;
+        window.term.markers;
       } catch (e) {
         window.throwMessage = e.message;
       }