Merge pull request #2450 from Tyriar/1158_throw_bad_open

Throw when open is called on element not on DOM
xtermjs · Oct 7, 2019 · 4fde8db · 4fde8db
2 parents e14b1f7 + 52ae8fc
commit 4fde8db
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/public/Terminal.ts b/src/public/Terminal.ts
@@ -56,6 +56,9 @@ export class Terminal implements ITerminalApi {
     this._core.resize(columns, rows);
   }
   public open(parent: HTMLElement): void {
+    if (!document.body.contains(parent)) {
+      throw new Error('open must be called on an element that is attached to the DOM');
+    }
     this._core.open(parent);
   }
   public attachCustomKeyEventHandler(customKeyEventHandler: (event: KeyboardEvent) => boolean): void {