Merge pull request #4438 from xtermjs/jerch-patch-1

fix BCE render bug in canvas renderer
xtermjs · Mar 15, 2023 · 21f48ba · 21f48ba
2 parents a359c7c + 49fdacb
commit 21f48ba
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/addons/xterm-addon-canvas/src/TextRenderLayer.ts b/addons/xterm-addon-canvas/src/TextRenderLayer.ts
@@ -96,10 +96,11 @@ export class TextRenderLayer extends BaseRenderLayer {
         }
 
         // exit early for NULL and SP
-        const code = cell.getCode();
-        if (code === 0 || code === 32) {
-          continue;
-        }
+        // NOTE: commented out due to #4120 (needs a more clever patch to keep things performant)
+        // const code = cell.getCode();
+        // if (code === 0 || code === 32) {
+        //  continue;
+        // }
 
         // Process any joined character ranges as needed. Because of how the
         // ranges are produced, we know that they are valid for the characters