Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StringLineGroup returns a count limited Enumerator #759

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Make StringLineGroup returns a count limited Enumerator #759

merged 5 commits into from
Dec 12, 2023

Conversation

Akarinnnnn
Copy link
Contributor

Fixes #757, before we return the array enumerator directly, enumerate it will get phantom empty lines.

@Akarinnnnn
Make StringLineGroup returns a count limited Enumerator
2ab716b 
Fixes xoofx#757, before we return the array enumerator directly, enumerate it will get phantom empty lines.
@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited

Pull Request Test Coverage Report for Build 7178678194

  • 30 of 33 (90.91%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 93.142%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Markdig/Helpers/StringLineGroup.cs 13 16 81.25%
Totals Coverage Status
Change from base Build 7030207683: 0.005%
Covered Lines: 26021
Relevant Lines: 27305
💛 - Coveralls

@xoofx xoofx changed the title (Personal info fixed) Make StringLineGroup returns a count limited Enumerator Make StringLineGroup returns a count limited Enumerator Dec 12, 2023
@xoofx xoofx added the bug label Dec 12, 2023
@xoofx xoofx merged commit 040a778 into xoofx:master Dec 12, 2023
1 check passed
@xoofx
Copy link
Owner

xoofx commented Dec 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoofx xoofx xoofx left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply foreach on class StringLineGroup got phantom empty line, is it expected?
3 participants
@Akarinnnnn @coveralls @xoofx