Unpin sphinx from 2.4.4 #3733
Merged
Unpin sphinx from 2.4.4 #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dannysepler! No news item needed here |
scopatz
reviewed
Sep 1, 2020
| @@ -1,6 +1,6 @@ | |||
| cloud_sptheme | |||
| numpydoc | |||
| Sphinx==2.4.4 | |||
| Sphinx>=3.1 | |||
There was a problem hiding this comment.
when i try that out, it seems to be failing. i think requirements.txt is looking for a version that satisfies both those conditions? but perhaps i'm mistaken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #3506 , 3.0.0 broke the docs, but 3.0.1 fixed the docs again. Pinning to 3.1, just to be safe. I clicked around locally and things seem to work.