X2-9733 | Make a Purchase Date Picker Month Dropdown Closes Intermitt… #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khomyakov
approved these changes
May 10, 2024
| ? ({ date }) => <MonthYearSelector date={date} currentMonth={currentMonth} onChange={handleMonthChange} /> | ||
| : undefined; | ||
| }, [shouldShowYearPicker, currentMonth]); |
There was a problem hiding this comment.
@VitalyDevico please add dependencies or suppress the warning
There was a problem hiding this comment.
ah yes, will add suppress now, along with comment, there shouldn't be handleMonthChange in depts
rushi
added a commit
to rushi/ui-kit
that referenced
this pull request
May 22, 2024
* 'master' of github.com:xola/ui-kit: X2-9733 | Make a Purchase Date Picker Month Dropdown Closes Intermitt… (xola#329) 2.3.3 XS-128 improve drawer design (xola#327) added comment to verify and remove this useEffect in datepicker, seem… (xola#328) 2.3.2 XS-25 fix(input): adds support for prefix and suffix while showing isRequired indicator (xola#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ently