Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to meow@7.0.1 #485

Closed
wants to merge 1 commit into from
Closed

Update to meow@7.0.1 #485

wants to merge 1 commit into from

Conversation

spl
Copy link

@spl spl commented Jun 11, 2020

This is an attempt to update meow to fix #471. I welcome any advice or even concrete changes to this branch. (I'm happy to open it up to others who want to work on it.)

Here's the report from npm test that I'm seeing:

  2 tests failed
  1 known failure

  cli-main › override default ignore

  cli-main › stdin-filename option with stdin

  ~/projects/xo/test/test/cli-main.js:30

  Value must match expression:

  `␊
    <text>:1:14␊
    ✖  1:14  Missing semicolon.  semi␊
  ␊
    1 error`

  Regular expression:

  /unicorn-file:/u

  cli › runs no-local install of XO

  ~/projects/xo/test/fixtures/config-files/xo_config_js/xo.config.js:3

   2:   esnext: true
   3: }             
   4:               

  Rejected promise returned by test. Reason:

  Error {
    command: '~/projects/xo/cli.js --no-local --version',
    exitCode: 1,
    failed: true,
    isCanceled: false,
    killed: false,
    shortMessage: 'Command failed with exit code 1: ~/projects/xo/cli.js --no-local --version',
    signal: undefined,
    signalDescription: undefined,
    stderr: '',
    stdout: `<snip>`,
    timedOut: false,
    message: `Command failed with exit code 1: ~/projects/xo/cli.js --no-local --version␊
    ␊
      test/fixtures/nested/file.js:1:1␊
      ✖  1:1   Unexpected var, use let or const instead.                                      no-var␊
      ✖  1:5   The variable obj should be named object. A more descriptive name will do too.  unicorn/prevent-abbreviations␊
      ✖  1:12  There should be no space after {.                                              object-curly-spacing␊
      ✖  1:17  There should be no space before }.                                             object-curly-spacing␊
    ␊
      test/fixtures/config-files/xo-config/file.js:1:1␊
      ✖  1:1   Unexpected var, use let or const instead.                                      no-var␊
      ✖  1:5   The variable obj should be named object. A more descriptive name will do too.  unicorn/prevent-abbreviations␊
      ✖  1:12  There should be no space after {.                                              object-curly-spacing␊
      ✖  1:17  There should be no space before }.                                             object-curly-spacing␊
    ␊
      test/fixtures/config-files/xo-config_json/file.js:1:1␊
      ✖  1:1   Unexpected var, use let or const instead.                                      no-var␊
      ✖  1:5   The variable obj should be named object. A more descriptive name will do too.  unicorn/prevent-abbreviations␊
      ✖  1:12  There should be no space after {.                                              object-curly-spacing␊
      ✖  1:17  There should be no space before }.                                             object-curly-spacing␊
    ␊
      test/fixtures/config-files/xo-config_js/file.js:1:1␊
      ✖  1:1   Unexpected var, use let or const instead.                                      no-var␊
      ✖  1:5   The variable obj should be named object. A more descriptive name will do too.  unicorn/prevent-abbreviations␊
      ✖  1:12  There should be no space after {.                                              object-curly-spacing␊
      ✖  1:17  There should be no space before }.                                             object-curly-spacing␊
    ␊
      test/fixtures/config-files/xo_config_js/file.js:1:1␊
      ✖  1:1   Unexpected var, use let or const instead.                                      no-var␊
      ✖  1:5   The variable obj should be named object. A more descriptive name will do too.  unicorn/prevent-abbreviations␊
      ✖  1:12  There should be no space after {.                                              object-curly-spacing␊
      ✖  1:17  There should be no space before }.                                             object-curly-spacing␊
    ␊
      test/fixtures/typescript/child/extra-semicolon.ts:1:31␊
      ✖  1:31  Extra semicolon.                                                               @typescript-eslint/semi␊
      ✖  1:31  Missing whitespace after semicolon.                                            semi-spacing␊
      ✖  1:32  Unnecessary semicolon.                                                         @typescript-eslint/no-extra-semi␊
    ␊
      test/fixtures/engines-overrides/promise-then-transpile.js:5:10␊
      ✖  5:10  example is defined but never used.                                             no-unused-vars␊
      ✖  6:17  Prefer await to then().                                                        promise/prefer-await-to-then␊
    ␊
      test/fixtures/engines-overrides/promise-then.js:5:10␊
      ✖  5:10  example is defined but never used.                                             no-unused-vars␊
    ␊
      test/fixtures/nested-configs/no-semicolon.js:1:28␊
      ✖  1:28  Missing semicolon.                                                             semi␊
    ␊
      test/fixtures/nested-configs/child/semicolon.js:1:25␊
      ✖  1:25  Extra semicolon.                                                               semi␊
    ␊
      test/fixtures/nested-configs/child-override/two-spaces.js:2:1␊
      ✖  2:1   Expected indentation of 4 spaces but found 2.                                  indent␊
    ␊
      test/fixtures/nested-configs/child-override/child-prettier-override/semicolon.js:1:25␊
      ✖  1:25  Delete ;                                                                       prettier/prettier␊
    ␊
      test/fixtures/typescript/two-spaces.tsx:2:1␊
      ✖  2:1   Expected indentation of 4 spaces but found 2.                                  @typescript-eslint/indent␊
    ␊
      test/fixtures/typescript/child/sub-child/four-spaces.ts:2:1␊
      ✖  2:1   Expected indentation of 2 spaces but found 4.                                  @typescript-eslint/indent␊
    ␊
      test/fixtures/config-files/xo_config_js/xo.config.js:3:2␊
      ✖  3:2   Missing semicolon.                                                             semi␊
    ␊
      33 errors`,
  }

  test/fixtures/config-files/xo_config_js/xo.config.js:3:2
  at makeError (node_modules/execa/lib/error.js:59:11)
  at handlePromise (node_modules/execa/index.js:114:26)
  at test/cli.js:10:19

@spl
Copy link
Author

spl commented Jun 11, 2020

Ah, the Travis-CI output is more readable than my local output, which overwrites all the short test messages. It says these are the two tests that fail:

  • ✖ cli-main › stdin-filename option with stdin
  • ✖ cli › runs no-local install of XO Rejected promise returned by test

@spl
Copy link
Author

spl commented Jun 11, 2020

It seems like if I just run ./cli.js, I get the second batch of errors. Could that be related to my node version (v14.4.0)?

@spl
Copy link
Author

spl commented Jun 12, 2020

Could that be related to my node version (v14.4.0)?

I tried with node v12.18.0 and saw similar problems. Note that I'm on macOS Mojave (10.14.6), if that makes a difference.

I'm happy to look into this further, but I need some guidance first. I suspect the solution would be easiest for @sindresorhus since (I believe) they maintain both xo and meow.

For now, I'll just leave this PR here.

@spl
Copy link
Author

spl commented Jun 18, 2020

Superseded by #489.

@spl spl closed this Jun 18, 2020
@spl spl deleted the update-meow branch June 18, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to the latest version of meow
1 participant