Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder Handler for ISO 8601 dates #174

Closed
spalreddy opened this issue Jan 21, 2020 · 5 comments
Closed

Placeholder Handler for ISO 8601 dates #174

spalreddy opened this issue Jan 21, 2020 · 5 comments
Assignees
Milestone

Comments

@spalreddy
Copy link

It would be useful to have placeholder handler for ISO 8601 date formats.

@spalreddy
Copy link
Author

i am considering making a pull request on this using java.time.format.DateTimeFormatter which is introduced in Java 8, thus making this library work only from java 8 onwards. Would it be acceptable ?

@bodewig
Copy link
Member

bodewig commented Jan 23, 2020

Sorry for the delay. The question isn't really that easy to answer :-)

I understand you want to use java.time over the mess that is SimpleDateFormat but bumping the Java requirement "just for that" feels a bit too much. OTOH it looks as if we'd start to alienate people who contribute by sticking with old APIs. Maybe we only change the requirements for the placeholders module? What do you think @krystiankaluzny ?

If we change the required version of Java we should make the next release 2.7.0 rather than a patch release.

@spalreddy
Copy link
Author

Agree with you. Upgrading to Java 8 may need its own valid reasons than just this. Let me find sometime to make Pre Java 8 compatible pull request.

@bodewig bodewig added this to the 2.6.5 milestone May 4, 2020
@bodewig bodewig self-assigned this May 4, 2020
@bodewig
Copy link
Member

bodewig commented May 4, 2020

I'll deal with this together with #178 and xmlunit/xmlunit.net/#31

@bodewig
Copy link
Member

bodewig commented May 10, 2020

I've by now implemented a isDateTime placeholder, it is available in the 2.7.0-SNAPSHOT build I've published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants