Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added placeholder for isDate #31

Merged
merged 7 commits into from May 6, 2020
Merged

Added placeholder for isDate #31

merged 7 commits into from May 6, 2020

Conversation

milkyware
Copy link
Contributor

@milkyware milkyware commented Apr 15, 2020

I use the ignore placeholder a lot but for timestamp fields, it'd be useful to check that the value is a valid date instead of ignoring it

@bodewig
Copy link
Member

bodewig commented Apr 20, 2020

Many thanks @milkyware

in some way this overlaps a bit with xmlunit/xmlunit#178 which adds optional arguments to placeholders and xmlunit/xmlunit#174 which asks for date matching placeholders and could benefit from optional patterns - which would also be a nice enhancement to your work here.

I intend to somehow merge the efforts but may need a while until I can find some spare time to actually do it.

@bodewig
Copy link
Member

bodewig commented May 6, 2020

many thanks @milkyware I'll merge this as is and will later extend it to accept an optional pattern.

I wonder whether isDateTime would be a better name than isDate as this confers the fact that dates and timestamps are accept better.

@bodewig bodewig merged commit 18c6308 into xmlunit:master May 6, 2020
bodewig added a commit that referenced this pull request May 6, 2020
@bodewig
Copy link
Member

bodewig commented May 12, 2020

I've just pushed the 2.8.0 packages to nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants