New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add lowercase of åäö in entityMap" #84
Conversation
Thanks! I may need some time to double-check before merging. I suspect that the issue could have been avoided had we started using using eslint or a derivative such as standard, as discussed in some other issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome finding!
Just checked, the removed keys are existing below.
Thanks for the contribution. I do have a few more nits for the future:
As I had implied before, it is not very nice when a revert would undo formatting cleanup. But I think taking it out would make it not a truly complete revert. I think PR #85 solved it by simply getting rid of the useless line. Once we have better test coverage, Stryker should show us if we have duplicated string entities again. On a positive note: kudos for putting the information into the revert commit itself. This should make it easier for people to understand the rationale without having to dig through GitHub. Thanks again for the contribution! |
This reverts commit ef20262.
These characters were already included lower in the file in the sorted
order for lower-case runes.
Including duplicates like this causes issues in Rhino 1.7.12:
Fixes: #83