Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update badges #78

Merged
merged 5 commits into from Jul 1, 2020
Merged

update badges #78

merged 5 commits into from Jul 1, 2020

Conversation

brodybits
Copy link
Member

  • remove badges from header line, including outdated Travis CI build
  • add newly formatted badges from shields.io, which also serve as links, one per line in the markdown

/cc @karfau

Copy link
Member

@karfau karfau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I would just recommend to have distinguishable link titles. It's a bit more accessible this way.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
brodybits and others added 3 commits July 1, 2020 02:10
Co-authored-by: Christian Bewernitz <coder@karfau.de>
Co-authored-by: Christian Bewernitz <coder@karfau.de>
Co-authored-by: Christian Bewernitz <coder@karfau.de>
[![license](https://img.shields.io/npm/l/xmldom?color=blue&style=flat-square)](./LICENSE.md)
[![npm](https://img.shields.io/npm/v/xmldom?style=flat-square)](https://www.npmjs.com/package/xmldom)
[![bug issues](https://img.shields.io/github/issues/xmldom/xmldom/bug?color=red&style=flat-square)](https://github.com/xmldom/xmldom/issues?q=is%3Aissue+is%3Aopen+label%3Abug)
[!["help wanted" issues](https://img.shields.io/github/issues/xmldom/xmldom/help%20wanted?color=darkgreen&style=flat-square)](https://github.com/xmldom/xmldom/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step further, maybe off-topic, would be to use a dash in the "help wanted" issues label, which I think would be just as clear and would make the hyperlinking a little easier in general. In the past I noticed that renaming an issues label would break old links, not sure if this is still the case or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change would have been easier to do before landing this.
I would assume that the links still break, but I don't know for sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was a little too quick to land the "help wanted" badge. I think not super tragic, though.

@brodybits brodybits merged commit f4ba214 into master Jul 1, 2020
@brodybits brodybits deleted the brodybits-update-badges branch July 1, 2020 06:21
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants