Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse internal entity declarations in internal DTD #367

Closed
wants to merge 9 commits into from
Closed

Parse internal entity declarations in internal DTD #367

wants to merge 9 commits into from

Commits on Jan 22, 2022

  1. Parse internal entity declarations in internal DTD

    @niklasl
    niklasl committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    d949b51 View commit details
    Browse the repository at this point in the history

  2. Stick to ES5 by consistently using var 

    Co-authored-by: Christian Bewernitz <coder@karfau.de>
    @niklasl @karfau
    niklasl and karfau committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    57e7cf3 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Use actual string length when sending characters 

    It may have been altered by XML entity expansion.
    @niklasl
    niklasl committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    3ad7fba View commit details
    Browse the repository at this point in the history

  2. Handle '>' in entity declaration values

    @niklasl
    niklasl committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    d10f537 View commit details
    Browse the repository at this point in the history

  3. Update tests to reflect added DOCTYPE processing 

    This reflects that the internal XML entities are now parsed and
expanded, and that an empty DOCTYPE is output.

Although the xmltest specs (from James Clark) do not contain these empty
DOCTYPE declarations, apparently Firefox and Chromium-based web browsers
do.
    @niklasl
    niklasl committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    4f65b78 View commit details
    Browse the repository at this point in the history

  4. Add notes regarding processing the internal subset 

    These replace the TODO:s about adding a parseInternalDTD method (as that
would require a more complex change).
    @niklasl
    niklasl committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    1aa4055 View commit details
    Browse the repository at this point in the history

  5. Adjust not-wf tests to reflect DOCTYPE processing 

    This reflects the now added somewhat lax internal DOCTYPE processing,
which now yields documents even with certain non-well-formed DOCTYPE:s.
    @niklasl
    niklasl committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    49b358f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Keep existing internal entity and issue warning

    @niklasl
    niklasl committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    311ffc3 View commit details
    Browse the repository at this point in the history

  2. Ignore unhandled forms of entity declarations 

    Make a more careful check for Parsed Entity (PEDef) forms to skip
embedded markup.
    @niklasl
    niklasl committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    0d665a5 View commit details
    Browse the repository at this point in the history