fix: Add doctype when parsing from string #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodybits
reviewed
Aug 25, 2021
| const { parser } = getTestParser() | ||
| const doc = parser.parseFromString( | ||
| '<!DOCTYPE html><body></body>', | ||
| MIME_TYPE.HTML |
There was a problem hiding this comment.
Just a random question if we should consider exporting these XML & HTML MIME types someday?
There was a problem hiding this comment.
Yes, I think it makes sense to publicly export the mime types and the name spaces.
brodybits
approved these changes
Aug 25, 2021
Comment on lines
+180
to
182
| this.doc.doctype = dt; | ||
| } | ||
| }, |
There was a problem hiding this comment.
Clearly outside the scope of the proposed changes but we should probably add a blank line here someday.
Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>
Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>
|
I merged from mobile device before the checks were done, one of the additional lines that was suggested was not OK for the linter. 64647d1 fixed that. |
This was referenced Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #277
It's not the nicest solution, since the property should actually be
readonly, but I think it's a good fix in the current situation.