New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): Copy types from DefinitelyTyped #283
Conversation
Let me check the changes locally before removing the draft status. If anyone spot anything in the meantime, feel free to raise it in the comments 🙂 I tried to keep the file as close to the original to avoid accidental breaking changes. UPD: I made the same changes locally and the typings were successfully read. Removing the draft status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pity we are loosing the tests that are present in DefinitlyTyped.
We should add them as before we make any relevant changes.
Besides that: LGTM
Yeah I completely agree on the tests. This fix we are making is quite rough, but it looks justified given the state of urgency 🙂 |
Need to get some sleep now, but will release it soon. |
This PR partially addresses #191 (see #191 (comment) → step 1). The file was copied from DefinitelyTyped.