Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use eslint-plugin-es5 to enforce ES5 #107

Merged
merged 3 commits into from
Aug 18, 2020
Merged

use eslint-plugin-es5 to enforce ES5 #107

merged 3 commits into from
Aug 18, 2020

Commits on Aug 18, 2020

  1. add eslint-plugin-es5 to devDependencies

    @brodybits
    brodybits committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    e20d277 View commit details
    Browse the repository at this point in the history

  2. add lib/.eslintrc.yml with extends: plugin:es5/no-es2015 entry 

    should guard against newer ES6 syntax that could lead to issues with
some ES5 environments such as:

- Jint - https://github.com/sebastienros/jint
- Duktape
- IE11
- Android pre-5.0 WebView (already past EOL)

as discussed in PR xmldom#91 - xmldom#91
    @brodybits
    brodybits committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    c09c9a8 View commit details
    Browse the repository at this point in the history

  3. add plugins entry with es5 to .eslintrc.yml

    @brodybits
    brodybits committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    4dbb226 View commit details
    Browse the repository at this point in the history