fix: typecheck source param before parsing (#113)

xmldom · Aug 26, 2020 · bd81fab · bd81fab
1 parent 3609c88
commit bd81fab
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/lib/dom-parser.js b/lib/dom-parser.js
@@ -21,7 +21,7 @@ DOMParser.prototype.parseFromString = function(source,mimeType){
 		defaultNSMap['']= 'http://www.w3.org/1999/xhtml';
 	}
 	defaultNSMap.xml = defaultNSMap.xml || 'http://www.w3.org/XML/1998/namespace';
-	if(source){
+	if(source && typeof source === 'string'){
 		sax.parse(source,defaultNSMap,entityMap);
 	}else{
 		sax.errorHandler.error("invalid doc source");

diff --git a/test/parse/simple.vows.js b/test/parse/simple.vows.js
@@ -46,7 +46,39 @@ wows.describe('parse').addBatch({
 		var dom = parser.parseFromString(xmlLineError, "text/xml");
 		var node = dom.documentElement.firstChild.nextSibling
 		assert(node.lineNumber, 7);
-  }
+  },
+  'invalid input - falsy string': runParserWith(''),
+  'invalid input - not a string': runParserWith({}),
+  'invalid input - number': runParserWith(12345),
+  'invalid input - null': runParserWith(null)
 }).export(module);
 
+function runParserWith (testValue) {
+  return function () {
+    var parser = new DOMParser(rethrowErrorHandler());
+
+    try {
+      parser.parseFromString(testValue);
+      // If the above line doesn't throw then fail the test
+      assert.isTrue(false);
+    } catch (e) {
+      assert.isTrue(isInvalidDocSource(e));
+    }
+  }
+}
+
+function rethrowErrorHandler () {
+  return {
+    errorHandler: {
+      error: function (errorMessage) {
+        throw errorMessage;
+      }
+    }
+  }
+}
 
+function isInvalidDocSource (errorMessage) {
+  // Errors that are thrown are embedded within a string containing locator data. Infer the original
+  // error message via regex
+  return /^\[xmldom error\][\s]*invalid doc source[\s\S]*$/.test(errorMessage);
+}