Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed error string #599

Merged
merged 2 commits into from
May 5, 2022
Merged

fixed error string #599

merged 2 commits into from
May 5, 2022

Conversation

kristinapathak
Copy link
Contributor

No description provided.

@kristinapathak kristinapathak added this to In progress in XMiDT via automation May 5, 2022
XMiDT automation moved this from In progress to PRs: Approved May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited

Codecov Report

Merging #599 (b063d03) into main (a0d45c5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   83.40%   83.44%   +0.03%     
==========================================
  Files         184      184              
  Lines        8541     8541              
==========================================
+ Hits         7124     7127       +3     
+ Misses       1207     1204       -3     
  Partials      210      210
Impacted Files Coverage Δ
device/handlers.go 87.80% <100.00%> (ø)
device/drain/drainer.go 98.59% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d45c5...b063d03. Read the comment docs.

@kristinapathak kristinapathak merged commit 4c34495 into main May 5, 2022
XMiDT automation moved this from PRs: Approved to Done May 5, 2022
@kristinapathak kristinapathak deleted the url-parsing branch May 5, 2022 21:31
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@denopink denopink mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

Assignees
No one assigned
Labels
bug
Projects
XMiDT
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristinapathak @kcajmagic