fix: update dependency postcss-normalize-charset to v5 (master) #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
the
📦 master
|
wait for |
renovate
bot
force-pushed
the
renovate/master-postcss-normalize-charset-5.x
branch
from
6acfcfc
to
fbc4a8c
Compare
renovate
bot
force-pushed
the
renovate/master-postcss-normalize-charset-5.x
branch
from
fbc4a8c
to
11e3b18
Compare
|
hmmm... version 5 of this node module was fixed for postcss 8 which now prints a warning on invalid imports postcss/postcss-import#447 explicitly adds a warning for the testcase we have in 3f420ca and does not add a "sloppy" option to skip those warnings |
|
@ZauberNerd we can add a silent option to postcss import if suppressing the warning is really required. lets check on monday, not clear 100% why we don't warn for invalid css |
previous versions of normalize-css did not log an error message, with this version error warnings are prited each time for invalid css. after double checking the bug reports in slack and also the initial PR, we came to the conclusion that we should default to print the error warning - especially as there is no "silent" option in normalize-css available. Co-authored-by: Björn Brauer <bjoern.brauer@new-work.se>
ZauberNerd
approved these changes
Aug 30, 2021
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^4.0.1->^5.0.0Release Notes
cssnano/cssnano
v5.0.1Compare Source
v5.0.0Compare Source
Major changes
Upgrade notes
If you use the cssnano JavaScript API, you need to change your code:
Replace
cssnano.process()withcssnano().process()(notice the()aftercssnano)pass cssnano options to
cssnano()instead ofprocess()Bug fixes
@font-facedeclarations #726postcss-nested#1004translate3d()minification #920e#589, #984aspect-ratio#963@supportsrules #974Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.