fix apache#7815 MultiMessageHandler should increase exception handlin…

…g to prevent data loss
xiaoheng1 · May 21, 2021 · b214bee · b214bee
1 parent 1a7ca1e
commit b214bee
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/...o-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/MultiMessageHandler.java b/...o-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/MultiMessageHandler.java
@@ -16,17 +16,21 @@
  */
 package org.apache.dubbo.remoting.transport;
 
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
 import org.apache.dubbo.remoting.Channel;
 import org.apache.dubbo.remoting.ChannelHandler;
+import org.apache.dubbo.remoting.ExecutionException;
 import org.apache.dubbo.remoting.RemotingException;
 import org.apache.dubbo.remoting.exchange.support.MultiMessage;
 
 /**
- *
  * @see MultiMessage
  */
 public class MultiMessageHandler extends AbstractChannelHandlerDelegate {
 
+    protected static final Logger logger = LoggerFactory.getLogger(MultiMessageHandler.class);
+
     public MultiMessageHandler(ChannelHandler handler) {
         super(handler);
     }
@@ -37,7 +41,12 @@ public void received(Channel channel, Object message) throws RemotingException {
         if (message instanceof MultiMessage) {
             MultiMessage list = (MultiMessage) message;
             for (Object obj : list) {
-                handler.received(channel, obj);
+                try {
+                    handler.received(channel, obj);
+                } catch (ExecutionException e) {
+                    logger.error("MultiMessageHandler received fail.", e);
+                    handler.caught(channel, e);
+                }
             }
         } else {
             handler.received(channel, message);