Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include xhtml2pdf package in wheel #737

Merged
merged 1 commit into from Nov 28, 2023

Conversation

carlsmedstad
Copy link
Contributor

Previously, the wheel included these top-level packages in addition to xhtml2pdf:

  • demo
  • docs
  • testrender

Resolves #736.

Previously, the wheel included these top-level packages in addition to
xhtml2pdf:

* demo
* docs
* testrender

Resolves xhtml2pdf#736.
Copy link
Collaborator

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlsmedstad Thanks a lot 🙏
And sorry it took me so long to review this! 😇

In general, this is a great improvement, however in my local environment, the folder tests is still included in the package, not sure why, maybe because of pypa/setuptools#3260?
Keeping the line exclude = ["tests*"] did not solve this for me. Maybe could you add prune tests to the MANIFEST.in? Or do you have a better idea?

@stefan6419846
Copy link
Contributor

How do you build your wheels? python -m build . seems to generate a wheel file which does not contain the tests.

@timobrembeck
Copy link
Collaborator

How do you build your wheels? python -m build . seems to generate a wheel file which does not contain the tests.

Yes, I'm using this command. My environment is:
OS: Arch linux (6.6.2-arch1-1)
Python: 3.11.6
pip: 23.2.1
build: 1.0.3
setuptools: 65.5.0

Ah, and yes, the wheel file does not contain the tests, but the sdist does.

@stefan6419846
Copy link
Contributor

stefan6419846 commented Nov 28, 2023

The sdist should contain the tests in most cases to allow upstream packaging by distro maintainers, thus this usually is correct.

@timobrembeck
Copy link
Collaborator

The sdist should contain the the tests in most cases to allow upstream packaging by distro maintainers, thus this usually is correct.

Ah ok makes sense, thanks for the clarification! 👍

@timobrembeck timobrembeck merged commit 76fface into xhtml2pdf:master Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel contains files & packages it shouldn't
3 participants