Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken sphinx build #631

Merged
merged 21 commits into from
Apr 17, 2024
Merged

Fix broken sphinx build #631

merged 21 commits into from
Apr 17, 2024

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Apr 15, 2024

Summary: This pins a buch of packages to deal with an issue that broke backwards compatibility for sphinx<5 (more info here: readthedocs/readthedocs.org#11140). I also moved all of the dependencies for the doce into doc/environment.yaml to avoid confusion/duplication vs dependencies defined in setup.py.

  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@navidcy
Copy link
Contributor

navidcy commented Apr 15, 2024

Do you need to add the compat requirement here:

xgcm/setup.py

Line 16 in 2bafd2a

"sphinx",

?

@IamShubhamGupto
Copy link

I was able to bump sphinx version by just hardcoding it in the environment.yml in #627 . Since the build seemed fine with v4.5.0, I just stuck to it

@jbusecke
Copy link
Contributor Author

I was able to bump sphinx version by just hardcoding it in the environment.yml in #627 . Since the build seemed fine with v4.5.0, I just stuck to it

I have done that here. This is so confusing!

@jbusecke
Copy link
Contributor Author

Do you need to add the compat requirement here:

xgcm/setup.py

Line 16 in 2bafd2a

"sphinx",

?

Trying that rn. Our whole build is very scattered. Ill dig further into this...sorry for this mess everyone.

@jbusecke
Copy link
Contributor Author

Ok I think I found what is going on:
From here
image
It seems they just inject another -sphinx to the environment file 🙈.

@jbusecke jbusecke changed the title Bump Sphinx version Fix broken sphinx build Apr 17, 2024
@jbusecke
Copy link
Contributor Author

Ok I am getting some releavant gh issues: readthedocs/readthedocs.org#11140 with a suggested workaround here. Going to give that a spin...

@jbusecke
Copy link
Contributor Author

Ok I gotta stop here. I moved all the docs requirements back to the conda env file (and removed them from the setup.py extras_require) since I was not able to get the build to run without installing pandoc via conda/mamba. At least this now is less confusing to the user who might have thought previously that you can build the docs with pip install ".[docs]" only.

My build locally succeeded (with a lot of warnings and things we should address), but If this passes I will merge and rely on #627 and follow ups to dig further into cleaning the whole process up.

Maybe we should just use jupyter-book to build the docs to github pages...this all seems extremly gnarly still.

@jbusecke
Copy link
Contributor Author

Thanks to @IamShubhamGupto for some of the work in #627 that we decided to factor out into this "fixing main" PR that can then be followed by a more thorough clean up of the docs.

@jbusecke
Copy link
Contributor Author

Nice this worked. Ill merge this now..

@jbusecke jbusecke enabled auto-merge (squash) April 17, 2024 21:12
@jbusecke jbusecke merged commit 33db3f2 into master Apr 17, 2024
6 checks passed
@jbusecke jbusecke deleted the sphinx>=5.0 branch April 18, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants