-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken sphinx build #631
Conversation
Do you need to add the compat requirement here: Line 16 in 2bafd2a
? |
I was able to bump |
Trying that rn. Our whole build is very scattered. Ill dig further into this...sorry for this mess everyone. |
Ok I think I found what is going on: |
Ok I am getting some releavant gh issues: readthedocs/readthedocs.org#11140 with a suggested workaround here. Going to give that a spin... |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Ok I gotta stop here. I moved all the docs requirements back to the conda env file (and removed them from the setup.py extras_require) since I was not able to get the build to run without installing pandoc via conda/mamba. At least this now is less confusing to the user who might have thought previously that you can build the docs with My build locally succeeded (with a lot of warnings and things we should address), but If this passes I will merge and rely on #627 and follow ups to dig further into cleaning the whole process up. Maybe we should just use jupyter-book to build the docs to github pages...this all seems extremly gnarly still. |
Thanks to @IamShubhamGupto for some of the work in #627 that we decided to factor out into this "fixing main" PR that can then be followed by a more thorough clean up of the docs. |
Nice this worked. Ill merge this now.. |
Summary: This pins a buch of packages to deal with an issue that broke backwards compatibility for sphinx<5 (more info here: readthedocs/readthedocs.org#11140). I also moved all of the dependencies for the doce into
doc/environment.yaml
to avoid confusion/duplication vs dependencies defined insetup.py
.pre-commit run --all-files
whats-new.rst