Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename boundary to padding. #578

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from
Draft

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Jan 27, 2023

Got really inspired by #557 and decided to try to build on top of that with a PR that renames boundary to padding (which makes it consistent with the nomenclature we discussed, and is already used in the padding.py module). This should lead to less confusion over the fact that we do not in fact implement physical boundary conditions yet.

This worked pretty well, except for a bunch of errors which all seem to have the same source.

FAILED xgcm/test/test_grid.py::test_dask_vs_eager[yperiodic_2d_left-extend-diff] - TypeError: diff_center_to_right() got an unexpected keyword argument 'padding'

There must be some place in the grid_ufunc internals where I have missed to rewire the logic to take padding instead of boundary. @TomNicholas, do you have a hunch what could be going on?


TomNicholas and others added 30 commits November 15, 2022 15:52
migrate transform logic from axis to grid
@jbusecke jbusecke marked this pull request as draft January 30, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants