-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename boundary
to padding
.
#578
Draft
jbusecke
wants to merge
39
commits into
xgcm:master
Choose a base branch
from
jbusecke:rename-boundary
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…to remove_Axis2
migrate transform logic from axis to grid
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…to remove_Axis2
for more information, see https://pre-commit.ci
…to remove_Axis2
for more information, see https://pre-commit.ci
…to remove_Axis2
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got really inspired by #557 and decided to try to build on top of that with a PR that renames
boundary
topadding
(which makes it consistent with the nomenclature we discussed, and is already used in thepadding.py
module). This should lead to less confusion over the fact that we do not in fact implement physical boundary conditions yet.This worked pretty well, except for a bunch of errors which all seem to have the same source.
There must be some place in the grid_ufunc internals where I have missed to rewire the logic to take
padding
instead ofboundary
. @TomNicholas, do you have a hunch what could be going on?pre-commit run --all-files
whats-new.rst
api.rst