Padding inside ufunc #447
Draft
Padding inside ufunc #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
commented
Mar 7, 2022
Comment on lines
+6
to
+16
| class Padder: | ||
| """ | ||
| Internal class which can pad numpy arrays, or compose a numpy ufunc with a particular padding operation. | ||
|
|
||
| One instance of the Padder class should be used for one padding operation, as its internals store the options chosen | ||
| for that particular use. | ||
| """ | ||
| grid: "Grid" | ||
| boundary_width: ... # TODO work out what all these types need to be | ||
| boundary: ... | ||
| fill_value: ... |
There was a problem hiding this comment.
@jbusecke I'm posting this as a WIP so you can see what I'm imagining here
TomNicholas
commented
Mar 7, 2022
Comment on lines
+493
to
+495
| # Compose the ufunc with the padding needed to replace trimmed elements | ||
| padder = Padder(grid, boundary_width_real_axes, boundary, fill_value) | ||
| pad_then_func = padder.compose_with(func) |
There was a problem hiding this comment.
Means that this is all the reference to padding I need to have in apply_as_grid_ufunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch of how we might refactor the code to pad inside the ufunc, as discussed in #443.
The idea is that all the complexity of composing the the padding operation with the desired ufunc operation is abstracted away into this
Padderclass, makingapply_as_grid_ufuncas simple as possible to understand.Also adds tests for the bug described in #436.
pre-commit run --all-fileswhats-new.rstapi.rst