implemented zpopmax, zpopmax with count #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
requested changes
Apr 10, 2019
sazzad16
requested changes
Apr 19, 2019
src/test/java/redis/clients/jedis/tests/commands/SortedSetCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/SortedSetCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/SortedSetCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/SortedSetCommandsTest.java
Outdated
Show resolved
Hide resolved
|
Have a look, please. |
sazzad16
approved these changes
Apr 22, 2019
|
LGTM! |
Closed
|
Any ETA on when this will be merged? @gkorland |
gkorland
reviewed
Oct 15, 2019
| @@ -285,6 +285,24 @@ public String toString() { | |||
|
|
|||
| }; | |||
|
|
|||
| public static final Builder<Tuple> TUPLE = new Builder<Tuple>() { | |||
There was a problem hiding this comment.
@z0mg can you please add a comment about the different between TUPLE_ZSET and TUPLE?
Or perhaps we better even rename this builder?
There was a problem hiding this comment.
@gkorland ZPOPMAX and ZPOPMIN without count returns only one Tuple. Returning a Tuple should be better instead of returning a Set of single Tuple. This builder helps on that purpose.
gkorland
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests under redis.clients.jedis.tests.commands.SortedSetCommandsTest.
Tried mimicking other binary asserts, but it looks like you can use any value for
expected.add(SafeEncoder.encode("x"));, they'll all pass.