Impl zpopmin zpopmax #1986
Closed
Impl zpopmin zpopmax #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZPOPMIN fixed after testing
implemented ZPOPMAX . created test for ZPOPMAX
|
Thx for contributing to Jedis. Can you please add this commands in |
|
Hello , I have added what i thought is missing and committed , after your warning. Do i need to open another pull request ? This is the first time i'm using this mechanism . Thank you |
|
@marcosnils We already have a pending PR for zpopmax at #1968 |
|
@sazzad16 how about zpopmin ? should i cancel or close this PR ? |
|
@kommradHomer yup, zpopmin is still needed. You can go ahead and send just that one. Apologies for the confusin. |
|
@kommradHomer Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented 2 commands for the Sorted Sets . ZPOPMIN and ZPOPMAX