Pluggable Regexpr Engine #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My hope is that by getting this into gojsonschema we can close out all the regexp issues and allow people to use whatever regex engine they want. FWIW, I agree that it should default to using golang's regexp while giving flexibility. |
|
@johandorland it would be great to get you to review this change. |
|
@johandorland I think we may need this support. Can you help to review this? please |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for plugging in different regular expression engines.
Anything that implements the
RegexpProviderinterface can be used in to do all the regexp matching. I'm not sold on the name of the interface or the name of the property inSchemaLoader, so I'm happy to take suggestions on the name.I added new tests for the functionality and verified that all the line I changed have test coverage.
Let me know what you think.
P.S. Sorry there is a little bit of noise in
README.mdas my editor striped trailing whitespace.