using jsoniter

[aadij]

• using json-iterator instead of encoding/json for better performance

[johandorland]

Do you have any number on how much faster this is going to be? From my experience JSON schema parsing itself is already quite heavy (and there are many areas that can easily be optimized). I'm not sure how much of an impact JSON encoding/decoding makes overall (especially when you use json-iterator in a compatibility mode). To me this feels like premature optimization and I somewhat like not having a dependency on a specific JSON parser, although feel free to change my mind.

[aadij]

validator-benchmarks (master) > go test -bench=BenchmarkX -benchmem validator_test.go 
goos: darwin
goarch: amd64
BenchmarkXeipuu-12                   200           7055320 ns/op         4604919 B/op      63053 allocs/op
BenchmarkXeipuuFork-12               200           6139997 ns/op         3803831 B/op      59141 allocs/op
PASS
ok      command-line-arguments  4.072s

Benchmark results using fork of validator-benchmarks

~13% saving in execution time and ~17% saving in memory usage per operation even in compatibility mode.

[aadij]

@johandorland are these improvements significant enough?

[johandorland]

I don't think the JSON schema test suite is particularly useful as its main purpose is for a validator to test their compliance to the spec . The schemas and documents in that test suite are all very small. If on more realistic schemas the numbers look similar it might be worth at least making JSON implementation pluggable.

[rainingmaster]

It well know that json-iterator is more faster than std json from here, and this project is also use in many other golang project, such as etcd, gin

[johandorland]

Etcd is an application and gin is a framework, which have more leniancy when it comes to making oppinionated choices. gojsonschema will often just be one of the libraries part of an application and I don't like having a dependency on a JSON parser.

After sleeping on this I think the root of this problem can be solved in a different manner. It's already possible for the user to directly pass parsed JSON using NewRawLoader. It's currently undocumented and tricky to use, but for these kind of use cases I think it makes perfect sense. The only thing I'm not sure about is if and what modifications need to be done to gojsonschema so it's less picky about it's raw input types. It doesn't seem like jsoniter use the exact same types as the standard library does.