Fix number formatting #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #247 |
…rorDetails() - Return a json.number err.Value() when an error occurs at a number - Remove old leftover float and integer number handling
johandorland
force-pushed
the
numberformat
branch
from
34d3e73
to
951a422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the internal numbers for minimum, maximum, exclusiveminimum and exclusivemaximum as
big.Floatinstead ofbig.Rat, which have a proper string representation. Furthermore this PR cleans up some old number handling when bignums were not supported. If an error occurs at a number,err.Value()now returns the rawjson.Numberinstead of a stringified parsed number value.