net.Conn for pageant with example and tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
Dec 10, 2023
| func New() (agent.Agent, net.Conn, error) { | ||
| if pageantWindow() != 0 { | ||
| return agent.NewClient(&conn{}), nil, nil | ||
| return agent.NewClient(&conn{}), &conn{}, nil |
There was a problem hiding this comment.
What is the point of returning a fake net.Conn here instead of just returning nil to indicate to a user there is no underlying net.Conn connection to be managed/closed?
I think we should omit this and also remove the methods you added for similarity with net.Conn.
I think
| } | ||
|
|
||
| type conn struct { | ||
| sync.Mutex | ||
| buf []byte | ||
| } | ||
|
|
||
| func (c *conn) Close() { | ||
| func (c *conn) Close() error { |
There was a problem hiding this comment.
I assume this is also done to mimic net.Conn? Inline with my other comment I suggest we do not mask this conn type so we can return it as some kind a fake net.Conn.
|
IMHO best: func New() net.Conn{...}
...
conn:=sshagent.New()
if conn==nil{
log.Fatalf(...
}
defer conn.Close()
ag:=agent.NewClient(conn)where conn from:
Maybe conn.Close() not important for &conn{} , but it's important for the rest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and examle works for me.
Congratulations on Programmer's Day!