Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of github actions used in lint_and_test #1926

Merged
merged 2 commits into from May 3, 2024

Conversation

heidiberry
Copy link
Contributor

Updating the versions of the github actions used in the lint and test pipeline.

This should remediate the warnings that appear when running the pipeline, e.g.:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@heidiberry
Copy link
Contributor Author

Confirmed that the original warnings have gone (e.g. https://github.com/xanzy/go-gitlab/actions/runs/8921003677).
However there are now some new warnings:

Restore cache failed: Dependencies file is not found in /home/runner/work/go-gitlab/go-gitlab. Supported file pattern: go.sum

According to actions/setup-go#427, this should be remedied by adding cache: false to the Install Go step, so I'll do that now.

@heidiberry
Copy link
Contributor Author

The pipeline has no warnings now

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heidiberry! LGTM 👍🏻

@svanharmelen svanharmelen merged commit f3f2bd3 into xanzy:main May 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants