Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attribute to project push rules #1921

Merged

Conversation

beekeep
Copy link
Contributor

@beekeep beekeep commented Apr 17, 2024

The commit_committer_name_check was missing from the project push rules. Also added tests for the project push rules.

The `commit_committer_name_check` was missing from the
project push rules.
@beekeep beekeep force-pushed the add-missing-attribute-project-push-rules branch from ecabda9 to fea7e17 Compare April 17, 2024 22:08
@beekeep
Copy link
Contributor Author

beekeep commented Apr 17, 2024

@svanharmelen This is ready for your review!

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beekeep! LGTM 👍🏻

@svanharmelen svanharmelen merged commit 5cf9a2e into xanzy:main Apr 18, 2024
3 checks passed
@beekeep beekeep deleted the add-missing-attribute-project-push-rules branch April 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants