Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EmailsEnabled to groups #1909

Conversation

PatrickRice-KSC
Copy link
Contributor

This PR adds support for the emails_enabled attribute to the Group APIs. This allows us to support that attribute in the Terraform provider prior to its removal in GitLab 17.0

@PatrickRice-KSC
Copy link
Contributor Author

@svanharmelen - This is ready for review. If you wouldn't mind cutting a new tag after this is merged so that we can update the TF provider, I'd appreciate it :)

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look good 👍🏻

@svanharmelen svanharmelen merged commit 3939b35 into xanzy:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants